Add hover style & flippable prop to Timepicker and Datepicker #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnieberg
changed the title
|
@tweettypography I'm going to add one more feature here, so please hold off on merging for now. |
|
Ok, it's good to go :) |
|
|
||
| storiesOf(TIME_PICKER, module) | ||
| .addDecorator(getStory => <div className="slds-p-around--medium">{getStory()}</div>) | ||
| .add('Base', () => getTimepicker({ stepInMinutes: 30, onDateChange: handleDateChange })) |
There was a problem hiding this comment.
Instead of this custom handleDateChange method you can actually just write onDateChange: action('onDateChange') to log your events in Storybook.
donnieberg
changed the title
donnieberg
force-pushed
the
timeDatePicker
branch
from
2d85696 to
5f8b29e
Compare
|
@tweettypography I made the flippable prop not default to true anymore. Would you please review again? |
|
actually.. let me bump the version and add this note to the changelog :) |
donnieberg
force-pushed
the
timeDatePicker
branch
from
84aa5c6 to
46a6ab6
Compare
|
Okie doke, good to go! |
donnieberg
force-pushed
the
timeDatePicker
branch
from
46a6ab6 to
85a758b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.