Skip to content

a few more tweaks to the lookup #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 2, 2015
Merged

a few more tweaks to the lookup #47

merged 9 commits into from
Nov 2, 2015

Conversation

xanthousphoenix
Copy link
Contributor

Fixes to some problems I noted...

  • needed to change how the listLength is determined
  • errors are rendered properly
  • wrapped contents of messages/errors in spans (we need to add some styles to the slds styles... I added them manually locally for now)
  • created a default empty message label (feel free to change, @madpotato)
  • overhaul on using the keyboard to navigate the list
  • safety check around using keyboard to select on an empty list with no header or footer

@xanthousphoenix
Copy link
Contributor Author

There seems to be a keyboard accessbility bug I introduced. Hold off on merge until I fix it.

@xanthousphoenix
Copy link
Contributor Author

Keyboard is correctly accessible again.

ivanbogdanov pushed a commit that referenced this pull request Nov 2, 2015
@ivansfdc
Merge pull request #47 from salesforce-ux/gpinto_more_lookup_modifica…
c6d4081 
…tions

a few more tweaks to the lookup
@ivanbogdanov ivanbogdanov merged commit c6d4081 into master Nov 2, 2015
@donnieberg donnieberg deleted the gpinto_more_lookup_modifications branch December 17, 2015 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xanthousphoenix @ivanbogdanov @minevskiy