Gut internal intermediate state from checkbox #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es the rendered DOM structure to match SLDS, previously we were spitting out non-compliant markup that wouldn't work for indeterminate.
…eeds-an-indeterminate-state-21
…rscore from _input in the main .jsx file.
…eeds-an-indeterminate-state-21
…tatable again. Updates indeterminate story to deal with new backwards-compatible data returned by onChange (checked [boolean], event, data [object {checked, indeterminate}]).
…eeds-an-indeterminate-state-21
… into GH-626---checkbox-needs-an-indeterminate-state-21
tweettypography
temporarily deployed
to
design-system-react-com-pr-751
interactivellama
force-pushed
the
GH-626---checkbox-needs-an-indeterminate-state-21
branch
from
e92e0f7 to
da4393c
Compare
interactivellama
deleted the
GH-626---checkbox-needs-an-indeterminate-state-21
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify checkbox logic. Assumption is that if you need a checkbox to be indeterminate, then it is a controlled component and does not need internal state.
@chriscorwin Tell me if there's an edge case I'm missing here.