Move internal sub-render components to private #783
Merged
+978
−1,102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This helps with engineers looking at the source code to find components they can use. See components/readme.md. - It will also help in excluding these private components All file renames here should be backwards compatible and alias file names will be present for the old files and removed at the next breaking change.
tweettypography
temporarily deployed
to
design-system-react-com-pr-783
|
LGTM! ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #779
privateorutilitiescan now be considered public API.All file renames here should be backwards compatible and alias file names will be present for the old files and removed at the next breaking change--except page-header. There were a lot of sub-rendering components in
page-headerwhich is a good thing, but from I can tell none are meant to public.