-
Notifications
You must be signed in to change notification settings - Fork 20
Fixes for issues #133 and #141 #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I didn't look in a great level of detail but does this support the delete animation when swiping both left and right? It looked like it was just the one way but, like I say, I didn't look in detail at what was going on, let alone actually test the PR. Thanks for this! The sample gif you posted looks awesome and is exactly what I had in mind. |
There will be both left and right animations in finished implementation. Thanks for pointing that out :) I'll remember about this from now on :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks great! Thanks for picking a transition-group based solution for this issue so no responsibilities are duplicated.
Anyway, could the basic example be kept and both of these displayed so for basic usage the example is a little simpler but right below, usage of transitions is showcased in a separate section/page?
src/module.d.ts
Outdated
@@ -10,6 +16,7 @@ export class SwipeableList extends React.Component<ISwipeableListProps> {} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider typing SwipeableList
children to allow properly typed callback as a child.
This looks excellent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Closes #133,
Closes #141