Skip to content

Fixes for issues #133 and #141 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 15, 2020
Merged

Conversation

marekrozmus
Copy link

@marekrozmus marekrozmus commented Apr 7, 2020

Closes #133,
Closes #141

2020-04-13_15-57-43

@jcuenod
Copy link

jcuenod commented Apr 7, 2020

I didn't look in a great level of detail but does this support the delete animation when swiping both left and right? It looked like it was just the one way but, like I say, I didn't look in detail at what was going on, let alone actually test the PR.

Thanks for this! The sample gif you posted looks awesome and is exactly what I had in mind.

@marekrozmus
Copy link
Author

There will be both left and right animations in finished implementation. Thanks for pointing that out :) I'll remember about this from now on :)

Copy link
Member

@przemyslawzalewski przemyslawzalewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great! Thanks for picking a transition-group based solution for this issue so no responsibilities are duplicated.
Anyway, could the basic example be kept and both of these displayed so for basic usage the example is a little simpler but right below, usage of transitions is showcased in a separate section/page?

@marekrozmus marekrozmus marked this pull request as ready for review April 13, 2020 13:59
src/module.d.ts Outdated
@@ -10,6 +16,7 @@ export class SwipeableList extends React.Component<ISwipeableListProps> {}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider typing SwipeableList children to allow properly typed callback as a child.

@jcuenod
Copy link

jcuenod commented Apr 14, 2020

This looks excellent

Copy link
Member

@przemyslawzalewski przemyslawzalewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@marekrozmus marekrozmus merged commit 86cd97a into master Apr 15, 2020
@marekrozmus marekrozmus deleted the fix_for_issue_133_and_141 branch April 15, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users should be able to opt out of the return tile animation. Feature: Animated Swipe to Delete
3 participants