Skip to content

fix: adjust children type to be compatible with React 18 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RafalPijet
Copy link
Contributor

@RafalPijet RafalPijet commented Dec 7, 2022

Based on issue #229, a children property was added to the ISwipeableListItemProps interface.

Fixes #229
Closes #233

@RafalPijet RafalPijet added the bug Something isn't working label Dec 7, 2022
@RafalPijet RafalPijet self-assigned this Dec 7, 2022
@RafalPijet
Copy link
Contributor Author

RafalPijet commented Dec 19, 2022

Empty content not supported:
Zrzut ekranu 2022-12-7 o 20 28 40

Current state without typing (before) on react 18:
Zrzut ekranu 2022-12-7 o 20 28 40 (1)

Test using React 18 where everything works:
Zrzut ekranu 2022-12-7 o 20 35 40
Zrzut ekranu 2022-12-7 o 20 35 54

Closes #229

@przemyslawzalewski przemyslawzalewski changed the title Add a fix of bug in ISwipeableListItemProps interface fix: adjust children type to be compatible with React 18 Dec 19, 2022
Add changes in ISwipeableListItemProps interface, package.json and README.md

fix: adjust children type to be compatible with React 18
@RafalPijet RafalPijet force-pushed the issue229_fix_bug_in_ISwipeableListItemProps_interface branch from eb4d5dd to 5a33117 Compare December 20, 2022 09:52
@przemyslawzalewski przemyslawzalewski merged commit 5f2f4c1 into master Dec 20, 2022
@przemyslawzalewski przemyslawzalewski deleted the issue229_fix_bug_in_ISwipeableListItemProps_interface branch December 20, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants