Skip to content

Push shell plug-in tutorials to production #22740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

AriannaMussoBarcucci
Copy link
Contributor

Pushing 'shell plug-in' and 'shell plug-in enrich' tutorials to production

Copy link
Collaborator

@MichaelCzcz MichaelCzcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please crop each screenshot's canvas to the actual screenshot size.

@jmmargo will follow up with the final review.

@AriannaMussoBarcucci
Copy link
Contributor Author

Please crop each screenshot's canvas to the actual screen
Hi Michael, the reason I needed to add padding to the screenshot, is for formatting issues: when I leave the screenshot to their actual size, the small ones are not correctly placed in the text (i.e: I add two spaces and then the image, which should result in the image being placed in the next line, but for small images this is not true and they are placed on the same line of the text, which makes the tutorial confusing and wrongly formatted). Can I ask if this requirement is a hard one? If yes, do you by any chance know of any other way to force the image on their own line? Thank you!

@jmmargo
Copy link
Contributor

jmmargo commented Jan 18, 2023

The <br/> tag can be used in the markdown to create line breaks.

@AriannaMussoBarcucci
Copy link
Contributor Author

I updated the tutorials as requested, and push them to production again. You can now go ahead with the final review, thank you!


![Final plugin](final_plugin.png)

### Test Yourself
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the tenth step. If you want the validation to appear in this step, you need to modify the VR file so that it states [VALIDATE_10] instead of [VALIDATE_9}.

@jmmargo jmmargo merged commit 67a98f3 into sap-tutorials:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants