Upgrade libsass to 3.5.0.beta1 #184
Conversation
|
|
||
| def __new__(cls, items, separator): | ||
| def __new__(cls, items, separator, bracketed): |
There was a problem hiding this comment.
It would be better if the added parameter has a default value for backward compatibility. 🤔
There was a problem hiding this comment.
yeah I considered that as well but wasn't really sure what to put. Both values seem equally wrong to me (though False was the only possible value before today).
On the other hand, it's super unlikely that consumers are even using this feature. At least internally we're only using sass functions to return strings and don't come close to dealing with maps or lists.
I guess I could change this to bracketed=False?
There was a problem hiding this comment.
If you meant giving any default value (True or False) is inappropriate, how about making this parameter to be False by default, but warn (i.e. DeprecationWarning) when it's not explicit?
There was a problem hiding this comment.
I just set it False by default. After a good night's sleep I figured this is a fine default since that used to be the only way.
Yay new beta!
Upstream has an abi breaking change which translates to a breaking change for us (
SassListnow has an additional required parameter)