Honor strip_extension option when building entire directory structures from distutils #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distutils build_sass command runs the Manifest.build() method, not the Manifest.build_one() method. The former does not honor the strip_extension option.
asottile
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well rested from my vacation, I was planning to look at a fix for #55, as discussed in #215. Then I was pleasantly surprised to find that #258 fixed it while I was away, and that #215 now could be closed :-)
However, I did not find #258 to work at all. The
build_sassbuild command invokesManifest.build(), which in turn invokes thebuild_directory()function to compile an entire directory structures of SASS files. #258 only patches and tests theManifest.build_one()method, which is apparently never invoked bybuild_sass.This PR attempts to remedy that.