Fix build issues with Clang compiler #371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git submodule libsass was pointing to deprecated url, see https://github.blog/2021-09-01-improving-git-protocol-security-github/#git-protocol-troubleshooting GCC compiler option gnu++0x is deprecated in favour of gnu++11. This eases a pain especially for those who want to build using Clang instead, as such option does not exist at all there. From GCC manual: gnu++11 gnu++0x GNU dialect of -std=c++11. The name gnu++0x is deprecated.
asottile
reviewed
Nov 2, 2021
| @@ -1,3 +1,3 @@ | |||
| [submodule "libsass"] | |||
| path = libsass | |||
| url = git://github.com/sass/libsass.git | |||
| url = git@github.com:/sass/libsass.git | |||
There was a problem hiding this comment.
would prefer https here so it's clonable by others without needing ssh keys (and in CI)
There was a problem hiding this comment.
Suggested change
| url = [email protected]:/sass/libsass.git | |
| url = https://sass/libsass.git |
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| MACOS_FLAG = ['-mmacosx-version-min=10.7'] | |||
| FLAGS_POSIX = [ | |||
| '-fPIC', '-std=gnu++0x', '-Wall', '-Wno-parentheses', '-Werror=switch', | |||
There was a problem hiding this comment.
gnu++0x gives us higher compatibility with older compilers so I would prefer this be rebased out
There was a problem hiding this comment.
yes, as this commit does not care about backwards compatibility closing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git submodule libsass was pointing to deprecated url, see https://github.blog/2021-09-01-improving-git-protocol-security-github/#git-protocol-troubleshooting
GCC compiler option gnu++0x is deprecated in favour of gnu++11. This eases a pain especially for those who want to build using Clang instead, as such option does not exist at all there.
From GCC manual:
gnu++11
gnu++0x
GNU dialect of -std=c++11. The name gnu++0x is deprecated.