Skip to content

Upgrade to libsass==3.1.0. Resolves #36. Resolves #38. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2015
Merged

Upgrade to libsass==3.1.0. Resolves #36. Resolves #38. #43

merged 2 commits into from
Feb 1, 2015

Conversation

asottile
Copy link
Member

Things this does:

This is a prerequisite to implementing #13

@asottile
Copy link
Member Author

oops, forgot to run the py3 tests, one sec lemme fixup my test

@coveralls
Copy link

Coverage Status

Coverage increased (+1.96%) to 72.04% when pulling 0259a57 on asottile:upgrade_to_cpp_api into 0cb44c3 on dahlia:python.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.96%) to 72.04% when pulling 0259a57 on asottile:upgrade_to_cpp_api into 0cb44c3 on dahlia:python.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.91%) to 72.99% when pulling 15df8fc on asottile:upgrade_to_cpp_api into 0cb44c3 on dahlia:python.

@dahlia
Copy link
Member

dahlia commented Jan 31, 2015

Now does it become to have to write @charset "UTF-8"; in order to use non-ASCII characters?

@dahlia
Copy link
Member

dahlia commented Jan 31, 2015

Anyway, huge thanks for your effort!

@asottile
Copy link
Member Author

This seems to be the PR which fixes the bug of not having @charset: sass/libsass#717

@dahlia
Copy link
Member

dahlia commented Feb 1, 2015

Okay, I will consider whether cherry-pick sass/libsass#717 or not, after merging this PR.

dahlia added a commit that referenced this pull request Feb 1, 2015
Upgrade to libsass==3.1.0.  Resolves #36.  Resolves #38.
@dahlia dahlia merged commit b043a03 into sass:python Feb 1, 2015
@asottile
Copy link
Member Author

asottile commented Feb 1, 2015

Here's my thoughts (I think you should keep it):

  1. Currently we're pointing at vanilla 3.1.0. Picking patches out of that would mean we don't support the same feature set as 3.1.0 (and we'd stop being a simple wrapper).
  2. Precedence:
    • npm node-sass: has @charset for files containing non-ASCII bytes
    • ruby-gem sass: has @charset for files containing non-ASCII bytes
  3. This spec-set: https://github.com/sass/sass-spec/blob/master/spec/basic/45_str_insert/input.scss https://github.com/sass/sass-spec/blob/master/spec/basic/45_str_insert/expected_output.css

@asottile asottile deleted the upgrade_to_cpp_api branch February 1, 2015 16:21
dahlia added a commit that referenced this pull request Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants