Skip to content

Pass scalac flags to the endpoint #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 13, 2017
Merged

Conversation

dominv
Copy link
Contributor

@dominv dominv commented Mar 7, 2017

This PR resolves #48 and adds the ability to pass scalac flags to the endpoint including the necessary tests.
It also adds the macroparadise plugin as a compiler plugin to the evaluator.

@raulraja could you please review?

Thanks!

@dominv dominv mentioned this pull request Mar 7, 2017
2 tasks
@dominv dominv changed the title WIP - Pass scalac flags to the endpoint Pass scalac flags to the endpoint Mar 10, 2017
@anamariamv anamariamv requested a review from raulraja March 13, 2017 09:55
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's get rid of all code and config that is not in use before this gets merged in

loaderio.verificationToken=${?LOADERIO_VERIFICATION_TOKEN}

allowed.compiler{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 if we are not using it


val AllowedCompilerFlags = "allowed.compiler.flags"

val allowedCompilerFlags = if (config.hasPath(AllowedCompilerFlags)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever is not in use 🔥

@dominv dominv merged commit 11119f5 into master Mar 13, 2017
@dominv dominv deleted the dv-48-pass-scalac-flags-endpoint branch March 13, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass scalac flags to the endpoint
2 participants