-
Notifications
You must be signed in to change notification settings - Fork 2
Pass scalac flags to the endpoint #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's get rid of all code and config that is not in use before this gets merged in
loaderio.verificationToken=${?LOADERIO_VERIFICATION_TOKEN} | ||
|
||
allowed.compiler{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 if we are not using it
|
||
val AllowedCompilerFlags = "allowed.compiler.flags" | ||
|
||
val allowedCompilerFlags = if (config.hasPath(AllowedCompilerFlags)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever is not in use 🔥
This PR resolves #48 and adds the ability to pass scalac flags to the endpoint including the necessary tests.
It also adds the macroparadise plugin as a compiler plugin to the evaluator.
@raulraja could you please review?
Thanks!