Update evaluator to Scala 2.13.1 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/src/main/scala/org/scalaexercises/evaluator/services.scala
Outdated
Show resolved
Hide resolved
juanpedromoreno
requested changes
Jan 31, 2020
server/src/main/scala/org/scalaexercises/evaluator/evaluation.scala
Outdated
Show resolved
Hide resolved
juanpedromoreno
requested changes
Feb 3, 2020
There was a problem hiding this comment.
There are also conflicts and warnings that would need to be fixed prior to merge this PR:
root>test:compile
[info] Formatting 4 Scala sources in ProjectRef(uri("file:/Users/juanpedromoreno/workspace/scala-exercises/evaluator/"), "evaluator-server") ...
[info] Compiling 1 Scala source to /Users/juanpedromoreno/workspace/scala-exercises/evaluator/server/target/scala-2.13/classes ...
[warn] -Xfuture is deprecated: Not used since 2.13.
[warn] one warning found
[info] Compiling 4 Scala sources to /Users/juanpedromoreno/workspace/scala-exercises/evaluator/server/target/scala-2.13/test-classes ...
[warn] -Xfuture is deprecated: Not used since 2.13.
[warn] /home/user/scala-exercises/evaluator/server/src/test/scala/org/scalaexercises/evaluator/EvaluatorSpec.scala:191:14: discarded non-Unit value
[warn] result should matchPattern {
[warn] ^
[warn] two warnings found
[success] Total time: 4 s, completed Feb 3, 2020 11:25:20 AM
juanpedromoreno
requested changes
Feb 3, 2020
server/src/test/scala/org/scalaexercises/evaluator/EvalEndpointSpec.scala
Outdated
Show resolved
Hide resolved
server/src/test/scala/org/scalaexercises/evaluator/EvalEndpointSpec.scala
Outdated
Show resolved
Hide resolved
# Conflicts: # server/src/main/scala/org/scalaexercises/evaluator/evaluation.scala # server/src/main/scala/org/scalaexercises/evaluator/services.scala
juanpedromoreno
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the evaluator to Scala 2.13.1. This PR is a Draft because we need to fix a memory leak which cause server crashes in heroku. Libraries updated. Updated Scala's compiler reporters.