Skip to content

Missing Employee definition #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2016
Merged

Missing Employee definition #28

merged 2 commits into from
Dec 26, 2016

Conversation

ricsirigu
Copy link
Contributor

No description provided.

@juanpedromoreno
Copy link
Contributor

Hi @ricsirigu, thanks for your time.

The Employee case class is defined here , which is the type that is being expected in this other place

@ricsirigu
Copy link
Contributor Author

Yeah, I know where it's defined.. but it's not defined in the exercise text :)

@juanpedromoreno
Copy link
Contributor

Oh, I see..

In that case, you need to include the definition within the comments ;)

juanpedromoreno
juanpedromoreno approved these changes Dec 26, 2016
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@juanpedromoreno juanpedromoreno merged commit 1b27ea6 into scala-exercises:master Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricsirigu @juanpedromoreno