Skip functions that pass arrays or structs by value #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornilova203
force-pushed
the
skip-illegal-scala-functions
branch
from
41e2526 to
9e7bb2d
Compare
Merged
jonas
reviewed
Jul 13, 2018
bindgen/ir/TypeDef.h
Outdated
| * @return true if the typedef is an alias for give type directly or through | ||
| * a chain of typedefs | ||
| */ | ||
| template <typename T> bool isAliasFor() const { |
There was a problem hiding this comment.
Isn't this a reimplementation of isAliasForType?
There was a problem hiding this comment.
That's true
I removed duplicate
jonas
approved these changes
Jul 13, 2018
| llvm::errs() | ||
| << "Warning: Function " << func->getName() | ||
| << " is skipped because Scala Native does not support " | ||
| "passing structs and arrays by value.\n"; |
There was a problem hiding this comment.
It would be nice to have a test for this. As I mentioned in another PR it might be preferable to do such testing in a separate test class.
|
It would be good to update the limitations doc to mention that such methods are skipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118