Fix underlying type of enums #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornilova203
force-pushed
the
fix-underlying-type-of-enums
branch
from
a22c2fa to
3a95e9c
Compare
kornilova203
commented
Jun 6, 2018
ir/Enum.cpp
Outdated
| s << ".toULong" << "\n"; | ||
| } else { | ||
| llvm::errs() << "Enum type is unsupported: " << e.type << "\n"; | ||
| llvm::errs().flush(); |
There was a problem hiding this comment.
This should not happen since uint64_t is unsigned long int
kornilova203
force-pushed
the
fix-underlying-type-of-enums
branch
from
6a05c15 to
de446f0
Compare
|
@jonas, I added types to enumerators, they used to be regular Scala types, now they are |
kornilova203
force-pushed
the
fix-underlying-type-of-enums
branch
from
de446f0 to
afc18ee
Compare
kornilova203
force-pushed
the
fix-underlying-type-of-enums
branch
from
afc18ee to
728c49b
Compare
jonas
reviewed
Jun 6, 2018
tests/samples/Enum.h
Outdated
|
|
||
| enum bigValues { | ||
| A = 10000000000, // does not fit into int | ||
| B = 1 |
There was a problem hiding this comment.
How about also adding a negative value?
There was a problem hiding this comment.
This is a good point, I totally forgot about negative numbers
jonas
reviewed
Jun 6, 2018
| final val enum_days_THURSDAY: enum_days = 3.toUInt | ||
| final val enum_days_FRIDAY: enum_days = 4.toUInt | ||
| final val enum_days_SATURDAY: enum_days = 5.toUInt | ||
| final val enum_days_SUNDAY: enum_days = 6.toUInt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #12