Skip to content

Simplify the example used for case objects. #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2021
Merged

Simplify the example used for case objects. #2172

merged 3 commits into from
Sep 16, 2021

Conversation

vlulla
Copy link
Contributor

@vlulla vlulla commented Aug 31, 2021

Also, fixed a small typo.

@bishabosha bishabosha requested a review from julienrf September 1, 2021 09:07
julienrf
julienrf reviewed Sep 3, 2021
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I prefer leaving the method calls and adding a comment saying that they must be defined somewhere else. What do you think?

@julienrf julienrf removed their assignment Sep 3, 2021
@vlulla vlulla closed this Sep 16, 2021
@SethTisue SethTisue reopened this Sep 16, 2021
@SethTisue SethTisue merged commit 28047b8 into scala:main Sep 16, 2021
@SethTisue
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

@julienrf julienrf julienrf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlulla @SethTisue @julienrf