-
Notifications
You must be signed in to change notification settings - Fork 1k
Add scala 3 contributing guide - MVP #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scala 3 contributing guide - MVP #2194
Conversation
…uide Minor fixes to compiler procedures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed "Procedures" so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that's the review for the Architecture.
Co-authored-by: Dale Wijnand <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
Co-authored-by: Sébastien Doeraene <[email protected]>
The old one is 404 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other reviewers probably have a lot more knowledge than me on this topic.
I wish I had this before my first spree!
I left some minor comments, but the guide looks very good and it contains a lot cool tips on testing. For the Spree I suggest to create a resume or shorter version, because there is a lot of material!
│ ├── ast // Abstract syntax trees | ||
│ ├── classpath | ||
│ ├── config // Compiler configuration, settings, platform specific definitions. | ||
│ ├── core // Core data structures and operations, with specific subpackages for: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier you mentioned a few phases (typer, parser) and @sjrd mentioned erasure...
Here I only see parser and typer. Where are the other phases?
part when you click it, or instrumenting variables for printing. | ||
|
||
An example of how it is done for Sublime Text 3 is [here](https://github.com/anatoliykmetyuk/scala-debug-sublime). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do other people in the team want to share their editor setup? I imagine most of them use VSCode so it would be nice to have helpers for it as well
Co-authored-by: Vinz <[email protected]>
Co-authored-by: Vinz <[email protected]>
Co-authored-by: Vinz <[email protected]>
Thanks everyone for the review and suggestions! I've applied the most straightforward ones while leaving more in-depth one for later. This is because we have only a couple days left until the spree, so we need to have something soon. Let's return to this PR in the future iterations of the development of this guide. |
this is the initial version of the Scala 3 contributing guide, optimised for dotty sprees.