Change installing munit to reflect changes in scala-cli #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
May 25, 2023
_includes/_markdown/install-munit.md
Outdated
| ``` | ||
| **However, MUnit won't be available in your source right away.** |
There was a problem hiding this comment.
That message sounds scary, I think it would be better to only give a note that the dependency will be available in test files only, which are files within a test directory or that have the .test.scala extension.
There was a problem hiding this comment.
Something along the way:
MUnit being a testing framework, it is only available in test files: files in a `test` directory or that have the `.test.scala` extension. Refer to the [Scala CLI documentation]() to learn more about the test scope.
There was a problem hiding this comment.
Good point. I fixed it.
adpi2
approved these changes
May 25, 2023
adpi2
reviewed
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged when scala-cli 1.0.0 is fully released.
https://github.com/VirtusLab/scala-cli/releases/tag/v1.0.0