cleanup #48
Merged
cleanup #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chef-client failed on windows because of the missing file this one just exits with error
... it turned `default['repos']['private']['pr-snap']` into an array, which didn't manifest until we were talking to jenkins through groovy btw, - chef-client must run on all nodes to update their attribs... - to show attribute: `knife node show $nodeName -a $attrName`
vagrant uses bridged networking -- use local /etc/hosts to point scala-ci.typesafe.com at the VM's ip test jenkins locally. (portforwarding wreaks havoc with reverse proxy & ssl)
Most attributes are set on all nodes, but some need to vary.
... rather than using template variables
adriaanm
changed the title
|
post-factum review by @lrytz -- going to push this into prod and make sure it doesn't break anything (mostly a refactor) |
|
lgtm - in the sense, didn't spot anything obvious. it's good to have me review changes, helps getting used to the codebase :) |
adriaanm
force-pushed
the
master
branch
2 times, most recently
from
352c57d to
f0607e1
Compare
adriaanm
added a commit
that referenced
this pull request
Apr 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default['repos']['private']['pr-snap']this is all laying the groundwork for moving to a new instance for scala-ci that also hosts artifactory (+ EBS storage for repo & jenkins jobs)