Skip to content

Update typo in 6.11 Blocks of specs #10142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

liang3zy22
Copy link
Contributor

No description provided.

@scala-jenkins scala-jenkins added this to the 2.13.10 milestone Sep 16, 2022
@liang3zy22 liang3zy22 changed the title Update typo in 6.11 Blocks Update typo in 6.11 Blocks of specs Sep 16, 2022
@liang3zy22
Copy link
Contributor Author

Already signed the CLA.

@SethTisue SethTisue added the documentation No code change. Only documentation label Sep 16, 2022
@@ -599,7 +599,7 @@ Evaluation of the block entails evaluation of its
statement sequence, followed by an evaluation of the final expression
´e´, which defines the result of the block.

A block expression `{´c_1´; ´\ldots´; ´c_n´; ´}` where ´s_1 , \ldots , s_n´ are
A block expression `{´s_1´; ´\ldots´; ´s_n´; }` where ´s_1 , \ldots , s_n´ are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meaning is: if the s_n of the block are case clauses c_n. So c is intended. The extra quote must be a typo, but the final semicolon is also a typo. Then the s_1 should just be c_1 etc. Note that this is not grammar syntax and the semicolons are also only for clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I got it. I didn't knew its actual meaning so made the first commit. I added a new commit, just removed the typo.

@liang3zy22
Copy link
Contributor Author

I merged the two commit into one. Hope it follows the procedure.

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We'll merge it after 2.13.9 is out.

@SethTisue SethTisue merged commit f151715 into scala:2.13.x Sep 19, 2022
@liang3zy22 liang3zy22 deleted the patch-blocks branch September 20, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation No code change. Only documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants