SI-8029 Avoid multi-run cyclic error with companions, package object #3229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dotta |
The bug report suggests this problem only became visible in the IDE *after* 2.10.3, but I tested an IDE with exactly 2.10.3 and saw the same problem. In fact, my test case fails as far back as 2.10.0. I suspect the problem showed up after 816cecf, which checks that pairs of companion symbols are codefined eagerly in Namers. This commit modifies the check of `rawInfo ne NoType` in `isCoDefinedWith` to avoid triggering adaptation of types from the previous run. I'm not sure of the precise intent of that check. I looked at c9861cd (genesis of isCoDefinedWith). Before that we get back to 3761cb4 (the dawn of Subversion.)
ghost
assigned
|
LGTM |
adriaanm
added a commit
that referenced
this pull request
Dec 9, 2013
SI-8029 Avoid multi-run cyclic error with companions, package object
|
/cc @xeno-by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug report suggests this problem only became visible in the
IDE after 2.10.3, but I tested an IDE with exactly 2.10.3 and
saw the same problem.
In fact, my test case fails as far back as 2.10.0. I suspect the
problem showed up after 816cecf, which checks that pairs of
companion symbols are codefined eagerly in Namers.
This commit modifies the check of
rawInfo ne NoTypein
isCoDefinedWithto avoid triggering adaptation of types fromthe previous run. I'm not sure of the precise intent of that check.
I looked at c9861cd (genesis of isCoDefinedWith). Before that we
get back to 3761cb4 (the dawn of Subversion.)
Review by @adriaanm