Skip to content

SI-8744 fix version.number in scaladoc.properties #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2015
Merged

SI-8744 fix version.number in scaladoc.properties #4628

merged 1 commit into from
Jul 16, 2015

Conversation

SethTisue
Copy link
Member

the fix is as suggested by Adriaan in the ticket

@SethTisue
SI-8744 fix version.number in scaladoc.properties
6a4ca9b 
the fix is as suggested by Adriaan in the ticket
@scala-jenkins scala-jenkins added this to the 2.11.8 milestone Jul 13, 2015
@SethTisue
Copy link
Member Author

nobody merge this till I've had the chance to look at the jars that Jenkins builds

@SethTisue SethTisue self-assigned this Jul 13, 2015
@SethTisue SethTisue removed the on-hold label Jul 16, 2015
@SethTisue
Copy link
Member Author

scaladoc.properties in https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots/org/scala-lang/scala-compiler/2.11.8-6a4ca9b-SNAPSHOT/scala-compiler-2.11.8-6a4ca9b-20150713.225637-1.jar appears correct to me:

#Mon, 13 Jul 2015 22:54:41 +0000

version.number=2.11.8-6a4ca9b-SNAPSHOT
maven.version.number=2.11.8-6a4ca9b-SNAPSHOT
osgi.version.number=2.11.8.v20150713-183748-6a4ca9b-SNAPSHOT-6a4ca9bafe
copyright.string=Copyright 2002-2013, LAMP/EPFL

review by @lrytz, who opened the original ticket

@SethTisue SethTisue removed their assignment Jul 16, 2015
@lrytz
Copy link
Member

lrytz commented Jul 16, 2015

LGTM

lrytz added a commit that referenced this pull request Jul 16, 2015
@lrytz
Merge pull request #4628 from SethTisue/issue/8744
be1de60 
SI-8744 fix version.number in scaladoc.properties
@lrytz lrytz merged commit be1de60 into scala:2.11.x Jul 16, 2015
@SethTisue SethTisue deleted the issue/8744 branch July 16, 2015 12:20
@scabug scabug mentioned this pull request Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.8
Development

Successfully merging this pull request may close these issues.
4 participants
@SethTisue @lrytz @adriaanm @scala-jenkins