Skip to content

SI-9406 fix doc for Range.takeRight #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2015
Merged

SI-9406 fix doc for Range.takeRight #4645

merged 1 commit into from
Jul 18, 2015

Conversation

SethTisue
Copy link
Member

No description provided.

@scala-jenkins scala-jenkins added this to the 2.11.8 milestone Jul 18, 2015
@SethTisue
Copy link
Member Author

review by @dickwall

@soc
Copy link
Contributor

soc commented Jul 18, 2015

Not @dickwall, but LGTM.

@dickwall
Copy link
Contributor

Can't see how this could have broken anything, but let's try a /rebuild anyway

@SethTisue
Copy link
Member Author

/rebuild

@SethTisue
Copy link
Member Author

(I don't think it's enough to just say "/rebuild" somewhere in a comment, it has to be a comment in itself.)

@SethTisue
Copy link
Member Author

sigh. failed again. investigating

@SethTisue
Copy link
Member Author

My old commit had the totally wrong parent. Not sure how I managed that. New commit should be good.

@SethTisue
Copy link
Member Author

hah, I know how I managed it. unlike the upstream repo, my fork of the scala repo still had a master branch, so when I accidentally did git checkout master && git checkout -b issue/9406 instead of git checkout 2.11.x && git checkout -b issue/9406, I didn't get an error. now fixed so the same mistake again won't be possible (deleted the master branch from my fork and made 2.11.x default)

SethTisue added a commit that referenced this pull request Jul 18, 2015
@SethTisue
Merge pull request #4645 from SethTisue/issue/9406
76c982e 
SI-9406 fix doc for Range.takeRight
@SethTisue SethTisue merged commit 76c982e into scala:2.11.x Jul 18, 2015
@SethTisue SethTisue deleted the issue/9406 branch July 18, 2015 17:51
@dickwall
Copy link
Contributor

Seth Tisue, in case I forget to say it again, you're my hero.

@SethTisue
Copy link
Member Author

wait until I commit a TWO line fix before I become your hero :-)

@scabug scabug mentioned this pull request Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.8
Development

Successfully merging this pull request may close these issues.
4 participants
@SethTisue @soc @dickwall @scala-jenkins