Accept .5 for half #6746
Merged
Accept .5 for half #6746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -242,6 +242,7 @@ class StringParsersTest { | |||
| "-0x0.000000000000090000000000000000001p-1022", | |||
| "-0x0.00000000000009fffffffffffffffffffffffffffffffffp-1022", | |||
| "-0x0.0000000000000fffffffffffffffffffffffffffffffffffp-1022", | |||
| ".4", | |||
There was a problem hiding this comment.
Can we get "", "." and "4." too while we're at it?
There was a problem hiding this comment.
OK, I was too busy with "half" puns.
There was a problem hiding this comment.
Maybe change to "0.5" then 👍
Previous refactor pruned too much by half.
som-snytt
force-pushed
the
review/6726-more
branch
from
44129d6 to
f94421e
Compare
|
reduce to two commits for merge...? |
As requested, more dotted tests. No benchmarks around the refactor.
som-snytt
force-pushed
the
review/6726-more
branch
from
f94421e to
86e7697
Compare
|
I squashed the new commits to .5 or half the total. |
|
The context is my hasty review of same. I was all ferocious about boolean expressions, irrespective of truth value. |
|
Woo-hoo, off to rebase all my outstanding PRs! Outstanding in both senses. |
|
out standing in the rain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous refactor pruned too much by half.