Skip to content

prepare to remove UninitializedError #7073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

hrhino
Copy link
Contributor

@hrhino hrhino commented Aug 14, 2018

It doesn't have any Scala-specific semantics and is unlikely to be worth more than a custom exception type to anyone currently using it.

If there's some reason to keep it around that I'm missing, please let me know.

@hrhino hrhino added this to the 2.12.7 milestone Aug 14, 2018
@sjrd
Copy link
Member

sjrd commented Aug 14, 2018

Isn't that the exception thrown by the codegen for -Xcheck-init?

@hrhino
Copy link
Contributor Author

hrhino commented Aug 14, 2018

that's what I thought at first, but that's actually UninitializedFieldError.

@NthPortal
Copy link
Contributor

Is there a reason to remove it for 2.13 rather than 2.14? I feel like it's a bit late in the cycle, if it's not a foot cannon

@hrhino
Copy link
Contributor Author

hrhino commented Aug 15, 2018

It doesn't need to go at all, in the objective sense.

However, it's in the scala namespace, and therefore imported by default in nearly every file (unless you use -Yno-imports or som's new thing in 2.13). It's also highly doubtful that it's useful, seeing as there's no way to even specify what is uninitialized.

All that said, I'm happy to rebase this on 2.13 and target the removal for 2.14. We could even not remove it at all.

@SethTisue
Copy link
Member

SethTisue commented Aug 15, 2018

I suggest that we deprecate in 2.12.7 and remove in 2.14.

@SethTisue
Copy link
Member

note that it's not necessary for the deprecation message to actually say which version it will be removed in, we usually just say "in a future release" or just leave it unstated

if there is an informal intention to hold the removal until 2.14, that could go in a code comment to keep it from getting caught up in a sweep

@hrhino hrhino force-pushed the kill/uninitializederror branch from 1ac81f3 to fa017b1 Compare August 15, 2018 16:31
@hrhino
Copy link
Contributor Author

hrhino commented Aug 15, 2018

Alright, I can go with that. Updated.

It doesn't have any Scala-specific semantics and is unlikely to be
worth more than a custom exception type to anyone currently using
it.
@hrhino hrhino force-pushed the kill/uninitializederror branch from fa017b1 to 7d17726 Compare August 15, 2018 16:32
@dwijnand
Copy link
Member

/rebuild

@adriaanm adriaanm merged commit 62b4e35 into scala:2.12.x Sep 7, 2018
@hrhino hrhino deleted the kill/uninitializederror branch September 10, 2018 18:40
@hrhino
Copy link
Contributor Author

hrhino commented Oct 23, 2020

This conversation did not age well. Presumably "removed in dotty".

@som-snytt
Copy link
Contributor

Maybe follow up with boopickle...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants