-
Notifications
You must be signed in to change notification settings - Fork 3.1k
prepare to remove UninitializedError #7073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Isn't that the exception thrown by the codegen for |
that's what I thought at first, but that's actually |
Is there a reason to remove it for 2.13 rather than 2.14? I feel like it's a bit late in the cycle, if it's not a foot cannon |
It doesn't need to go at all, in the objective sense. However, it's in the All that said, I'm happy to rebase this on 2.13 and target the removal for 2.14. We could even not remove it at all. |
I suggest that we deprecate in 2.12.7 and remove in 2.14. |
note that it's not necessary for the deprecation message to actually say which version it will be removed in, we usually just say "in a future release" or just leave it unstated if there is an informal intention to hold the removal until 2.14, that could go in a code comment to keep it from getting caught up in a sweep |
1ac81f3
to
fa017b1
Compare
Alright, I can go with that. Updated. |
It doesn't have any Scala-specific semantics and is unlikely to be worth more than a custom exception type to anyone currently using it.
fa017b1
to
7d17726
Compare
/rebuild |
This conversation did not age well. Presumably "removed in dotty". |
Maybe follow up with boopickle... |
It doesn't have any Scala-specific semantics and is unlikely to be worth more than a custom exception type to anyone currently using it.
If there's some reason to keep it around that I'm missing, please let me know.