fix warnings. avoid IterableOnce deprecated methods #7150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwei-k
commented
Aug 30, 2018
| else { | ||
| prefix.size match { | ||
| prefix.iterator.size match { |
There was a problem hiding this comment.
Maybe this changes fix scala/bug#11122 by chance. But current implementation not efficient.
There was a problem hiding this comment.
revert this changes. create another pull request #7153
xuwei-k
force-pushed
the
IterableOnce-deprecated-methods
branch
from
88148c6 to
b8849fc
Compare
NthPortal
reviewed
Aug 31, 2018
| @@ -396,7 +396,7 @@ final class LazyList[+A] private(private[this] var lazyState: () => LazyList.Sta | |||
|
|
|||
| override def zip[B](that: collection.IterableOnce[B]): LazyList[(A, B)] = | |||
| newLL { | |||
| if (this.isEmpty || that.isEmpty) State.Empty | |||
| if (this.isEmpty || that.iterator.isEmpty) State.Empty | |||
There was a problem hiding this comment.
you can leave these LazyList fixes out - they will be fixed in #7139
xuwei-k
force-pushed
the
IterableOnce-deprecated-methods
branch
from
b8849fc to
1095495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.