Skip to content

use SAM conversion for Equiv instances #7159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2018
Merged

use SAM conversion for Equiv instances #7159

merged 1 commit into from
Sep 3, 2018

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Sep 1, 2018

No description provided.

@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Sep 1, 2018
NthPortal
NthPortal approved these changes Sep 1, 2018
View reviewed changes
Copy link
Contributor

@NthPortal NthPortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it's not entirely clear to me why some have { } around them and some don't; personally, I'd prefer if none had { } around them

@lrytz lrytz merged commit 95be3ff into scala:2.13.x Sep 3, 2018
@xuwei-k xuwei-k deleted the Equiv-SAM branch September 3, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NthPortal NthPortal NthPortal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@xuwei-k @NthPortal @lrytz @scala-jenkins