Skip to content

Revert "GenASM: pipeline disk-write with building of classfiles" #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2012

Conversation

dragos
Copy link
Contributor

@dragos dragos commented Jul 10, 2012

This reverts commit 5d12fa4.

This is a temporary solution to unblock the IDE for M5. A background thread can't make changes to the Eclipse workspace without acquiring the proper locks.

@scala-jenkins
Copy link

Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/471/

@gkossakowski
Copy link
Contributor

Worth mentioning that @magarciaEPFL proposed this (temporary) solution. If build passes then it gets LGTM from me.

@scala-jenkins
Copy link

jenkins job pr-scala-testsuite-linux-opt: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/471/

@dragos
Copy link
Contributor Author

dragos commented Jul 10, 2012

Yes, sorry I forgot to mention that, and a reviewer. There, review by @gkossakowski, @magarciaEPFL

@magarciaEPFL
Copy link
Contributor

LGTM

adriaanm pushed a commit that referenced this pull request Jul 10, 2012
Revert "GenASM: pipeline disk-write with building of classfiles"
@adriaanm adriaanm merged commit 026a70d into scala:master Jul 10, 2012
@adriaanm
Copy link
Contributor

@dragos, I was just reminded of this PR -- looks like the "temporary" measure is still in place :-)
Could we bring back the parallelism in 2.11.1?

@dragos
Copy link
Contributor Author

dragos commented Mar 21, 2014

It's been on my todo list for a while now. Since we moved to the Sbt builder, it should be possible now. The simplest next step would be to open a PR with this change, and let the PR validation do its thing.

@adriaanm
Copy link
Contributor

Cool! Will do for 2.11.1-RC1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants