Skip to content

fix sameCBF in TreeSet and TreeMap #8952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2020
Merged

fix sameCBF in TreeSet and TreeMap #8952

merged 1 commit into from
May 4, 2020

Conversation

mkeskells
Copy link
Contributor

CanBuildFrom checking in TreeSet and TreeMap improved, and removed a benign bug

@scala-jenkins scala-jenkins added this to the 2.12.12 milestone May 3, 2020
@mkeskells mkeskells requested review from hrhino and retronym May 3, 2020 13:54
@mkeskells
Copy link
Contributor Author

Mima issues


[error]  * method factory()scala.collection.generic.SortedMapFactory in class scala.collection.generic.SortedMapFactory#SortedMapCanBuildFrom does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.generic.SortedMapFactory#SortedMapCanBuildFrom.factory")
[error]  * method factory()scala.collection.generic.SortedSetFactory in class scala.collection.generic.SortedSetFactory#SortedSetCanBuildFrom does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.generic.SortedSetFactory#SortedSetCanBuildFrom.factory")
[error]  * method ordering()scala.math.Ordering in class scala.collection.generic.SortedSetFactory#SortedSetCanBuildFrom does not have a correspondent in other version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.generic.SortedSetFactory#SortedSetCanBuildFrom.ordering")

@mkeskells mkeskells force-pushed the 2.12.x_TreeMap_TreeSet_sameCBF branch from ec372ba to 4f4f9dc Compare May 3, 2020 21:34
@lrytz lrytz merged commit 621f104 into scala:2.12.x May 4, 2020
@SethTisue SethTisue added the library:collections PRs involving changes to the standard collection library label May 5, 2020
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
@lrytz
Merge pull request scala/scala#8952 from mkeskells/2.12.x_TreeMap_Tre…
06c6e18 
…eSet_sameCBF
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
@lrytz
Merge pull request scala/scala#8952 from mkeskells/2.12.x_TreeMap_Tre…
697f2aa 
…eSet_sameCBF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

@hrhino hrhino Awaiting requested review from hrhino

@retronym retronym Awaiting requested review from retronym

Assignees
No one assigned
Labels
library:collections PRs involving changes to the standard collection library
Projects
None yet
Milestone
2.12.12
Development

Successfully merging this pull request may close these issues.
4 participants
@mkeskells @lrytz @SethTisue @scala-jenkins