CRs. Change logic to use definitions instead of show

Author: pikinier20

scaladoc/src/dotty/tools/scaladoc/tasty/JavadocAnchorCreator.scala

@@ -11,24 +11,27 @@ trait JavadocAnchorCreator:
   import self.q.reflect._
 
   private val javadocPrimitivesMap = Map(
-    "scala.Int" -> "int",
-    "scala.Float" -> "float",
-    "scala.Double" -> "double",
-    "scala.Long" -> "long",
-    "scala.Byte" -> "byte",
-    "scala.Boolean" -> "boolean",
-    "scala.Char" -> "char",
-    "scala.Short" -> "short",
-    "<special-ops>.<FromJavaObject>" -> "java.lang.Object"
+    defn.IntClass -> "int",
+    defn.FloatClass -> "float",
+    defn.DoubleClass -> "double",
+    defn.LongClass -> "long",
+    defn.ByteClass -> "byte",
+    defn.BooleanClass -> "boolean",
+    defn.CharClass -> "char",
+    defn.ShortClass -> "short",
+    defn.ObjectClass -> "java.lang.Object"
   )
 
-  private def transformPrimitiveType(s: String): String = javadocPrimitivesMap.getOrElse(s, s)
+  private def transformPrimitiveType(tpe: TypeRepr): String = tpe.classSymbol
+    .flatMap(javadocPrimitivesMap.get)
+    .filter(_ => !tpe.typeSymbol.isTypeParam)
+    .getOrElse(tpe.show)
 
   private def transformType(tpe: TypeRepr): String = tpe.simplified match {
-    case AppliedType(tpe, typeList) if tpe.show == "scala.Array" =>  transformType(typeList.head) + ":A"
-    case AppliedType(tpe, typeList) if tpe.show == "scala.<repeated>" => transformType(typeList.head) + "..."
-    case AppliedType(tpe, typeList) => transformPrimitiveType(tpe.show)
-    case other => transformPrimitiveType(other.show)
+    case AppliedType(tpe, typeList) if tpe.classSymbol.fold(false)(_ == defn.ArrayClass) => transformType(typeList.head) + ":A"
+    case AppliedType(tpe, typeList) if tpe.classSymbol.fold(false)(_ == defn.RepeatedParamClass) => transformType(typeList.head) + "..."
+    case AppliedType(tpe, typeList) => transformPrimitiveType(tpe)
+    case other => transformPrimitiveType(other)
   }
 
   def getJavadocType(s: TypeRepr) = transformType(s)

scaladoc/src/dotty/tools/scaladoc/tasty/SymOps.scala

@@ -3,11 +3,16 @@ package tasty
 
 import scala.quoted._
 import dotty.tools.scaladoc.util.Escape._
+import scala.collection.mutable.{ Map => MMap }
+import dotty.tools.io.AbstractFile
 
 class SymOps[Q <: Quotes](val q: Q) extends JavadocAnchorCreator with Scaladoc2AnchorCreator:
   import q.reflect._
 
   given Q = q
+
+  private val externalLinkCache: scala.collection.mutable.Map[AbstractFile, Option[ExternalDocLink]] = MMap()
+
   extension (sym: Symbol)
     def packageName: String = (
       if (sym.isPackageDef) sym.fullName
@@ -163,9 +168,14 @@ class SymOps[Q <: Quotes](val q: Q) extends JavadocAnchorCreator with Scaladoc2A
             import dotty.tools.dotc
             given ctx: dotc.core.Contexts.Context = q.asInstanceOf[scala.quoted.runtime.impl.QuotesImpl].ctx
             val csym = sym.asInstanceOf[dotc.core.Symbols.Symbol]
-            Option(csym.associatedFile).map(_.path).flatMap( path =>
-              dctx.externalDocumentationLinks.find(_.originRegexes.exists(r => r.matches(path)))
-            ).map(link => constructPath(location, anchor, link))
+            val extLink = if externalLinkCache.contains(csym.associatedFile) then externalLinkCache(csym.associatedFile)
+            else {
+              val calculatedLink = Option(csym.associatedFile).map(_.path).flatMap( path =>
+               dctx.externalDocumentationLinks.find(_.originRegexes.exists(r => r.matches(path))))
+              externalLinkCache += (csym.associatedFile -> calculatedLink)
+              calculatedLink
+            }
+            extLink.map(link => constructPath(location, anchor, link))
         }
 
         DRI(