Skip to content

Load tasty files directly in -from-tasty tests #10009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2020
Merged

Load tasty files directly in -from-tasty tests #10009

merged 4 commits into from
Oct 16, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 15, 2020 •
edited
Loading

  • Load tasty files directly in -from-tasty tests
  • Avoid pickling nested packages with only imports, which fix an unrelated bug discovered by the first change

@nicolasstucki nicolasstucki self-assigned this Oct 15, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review October 16, 2020 07:03
liufengyun
liufengyun approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit f3a4640 into scala:master Oct 16, 2020
@liufengyun liufengyun deleted the load-tasty-files-directly-in-tests branch October 16, 2020 17:02
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @Kordyjan