Skip to content

Rename Type.T to Type.Underlying #10097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

After #10045 we do not have any cases where we need to use this type reference explicitly in the source code.
We rename it to have a descriptive name to improve error messages and to push users to use the canonical representation of types and never use them explicilty.

After scala#10045 we do not have any cases where we need to use this type reference explicitly in the source code.
We rename it to have a descriptive name to improve error messages and to push users to use the canonical representation of types and never use them explicilty.
@nicolasstucki nicolasstucki marked this pull request as ready for review October 27, 2020 16:37
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 19e47b7 into scala:master Oct 28, 2020
@nicolasstucki nicolasstucki deleted the rename-Type-underlying-type branch October 28, 2020 06:57
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants