Use standard annotation format for dollarvalues #10101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enum companions define the following: val $values: Array[E] @unchecked = ... currently the @unchecked annotation is represented as New(typeOf[scala.unchecked]) it should be Apply(Select(New(typeOf[scala.unchecked]), <init>), Nil)
smarter
reviewed
Oct 27, 2020
| @@ -125,7 +125,7 @@ object DesugarEnums { | |||
| // Singleton enum values always construct a new anonymous class, which will not be checked by the init-checker, | |||
| // so this warning will always persist even if the implementation of the anonymous class is safe. | |||
| // TODO: remove @unchecked after https://github.com/lampepfl/dotty-feature-requests/issues/135 is resolved. | |||
| Annotated(ArrayLiteral(enumValues, rawEnumClassRef), New(ref(defn.UncheckedAnnot.typeRef))) | |||
There was a problem hiding this comment.
If this isn't supposed to be supported, we need a check somewhere to disallow it. What happens if a macro constructs such a tree?
There was a problem hiding this comment.
I opened the issue #10113 for this
smarter
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enum companions define the following:
currently the
@uncheckedannotation is represented asNew(typeOf[scala.unchecked])it should be
this ends up with a special case in TASTy