Disallow interpretation of arbitrary calls in parameters #10103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the macro call should be interpreted. The code within the parameters should only contain quoted code and literal constants.
In the future, we could support having arbitrary code in the macros, but it should be done the right way. The code within the top-level splice should be precompiled and that code would be executed when calling the macro.
Migration
Future
Now that we have compilation unit suspension we could auto-generate the intermediary implementation and place it in a global object that gets compiled first. This is not a priority as it does not provide any extra functionality, it can always be written down explicitly.