Scala3doc: fix issues with loading stdlib #10340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Nov 16, 2020
abgruszecki
force-pushed
the
load-stdlib
branch
2 times, most recently
from
0875367 to
7d9e02a
Compare
abgruszecki
force-pushed
the
load-stdlib
branch
from
7d9e02a to
674a589
Compare
Avoid Tasty errors, and allows us to use wiki syntax for the project.
romanowski
reviewed
Nov 18, 2020
| @@ -1506,15 +1508,24 @@ object Build { | |||
| (`scala3-interfaces`/Compile/products).value, | |||
| (`tasty-core-bootstrapped`/Compile/products).value, | |||
| (`scala3-library-bootstrapped`/Compile/products).value, | |||
| // TODO we can't load stdlib from Tasty | |||
There was a problem hiding this comment.
IMHO we should leave this here until we will be able to generate stdlib togeter with rest of Scala3 jars
There was a problem hiding this comment.
We have a similar comment above, where we define generateScala3StdlibDocumentation.
| ).flatten | ||
|
|
||
| val roots = joinProducts(dottyJars) | ||
|
|
||
| if (dottyJars.isEmpty) Def.task { streams.value.log.error("Dotty lib wasn't found") } | ||
| else generateDocumentation(roots, "Scala 3", "scala3", "-p scala3doc/scala3-docs --projectLogo scala3doc/scala3-docs/logo.svg --revision master") | ||
| }.value, | ||
|
|
||
| generateScala3StdlibDocumentation:= Def.taskDyn { | ||
| val dottyJars: Seq[java.io.File] = Seq( |
There was a problem hiding this comment.
it should be stdLibJars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.