Skip to content

Fix #10563: Handle static methods in non-native JS classes. #10564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix #10563: Handle static methods in non-native JS classes. #10564

merged 1 commit into from
Dec 1, 2020
+28 −13

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Nov 30, 2020

Static methods can be generated in non-native JS classes for lambdas that do not refer to the enclosing this value.

@sjrd
Fix scala#10563: Handle static methods in non-native JS classes.
8d40763 
Static methods can be generated in non-native JS classes for
lambdas that do not refer to the enclosing `this` value.
@sjrd sjrd added this to the 3.0.0-M3 milestone Nov 30, 2020
@sjrd sjrd requested a review from nicolasstucki November 30, 2020 17:12
@sjrd sjrd linked an issue Nov 30, 2020 that may be closed by this pull request
Scala.js: top-level JS class with lambdas that become static causes assertion error in back-end #10563
Closed
@sjrd sjrd merged commit b2a66ac into scala:master Dec 1, 2020
@sjrd sjrd deleted the sjs-fix-static-methods-in-jsclass branch December 1, 2020 12:08
@Kordyjan Kordyjan modified the milestones: 3.0.0-M3, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Scala.js: top-level JS class with lambdas that become static causes assertion error in back-end
3 participants
@sjrd @nicolasstucki @Kordyjan