Skip to content

Remove library methods deprecated in M3 #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Dec 17, 2020

  • Remove scala.deriving.{ArrayProduct, EmptyProduct, productElement}
  • Remove scala.quoted.Quotes.reflect.{Tree.of, Term.of}
  • Remove scala.quoted.{Unlifted, Const, Consts}
  • Update community-build: Term.of(x) -> x.asTerm

@nicolasstucki nicolasstucki self-assigned this Dec 17, 2020
@nicolasstucki nicolasstucki force-pushed the remove-deprecated-methods-from-library branch 5 times, most recently from b7b068b to f2123af Compare December 17, 2020 16:10
@nicolasstucki nicolasstucki marked this pull request as ready for review December 17, 2020 16:36
@anatoliykmetyuk
Copy link
Contributor

CI failed:

2020-12-17T16:50:26.2746023Z [error] -- [E006] Not Found Error: /__w/dotty/dotty/community-build/community-projects/upickle/implicits/src-3/upickle/implicits/CaseClassReader.scala:67:24 
2020-12-17T16:50:26.2747471Z [error] 67 |          m.fromProduct(ArrayProduct(values.toArray))
2020-12-17T16:50:26.2748287Z [error]    |                        ^^^^^^^^^^^^
2020-12-17T16:50:26.2748858Z [error]    |                        Not found: ArrayProduct
2020-12-17T16:50:27.6961030Z [error] one error found

And a bunch of other errors like that involving ArrayProduct.

* Remove `scala.deriving.{ArrayProduct, EmptyProduct, productElement}`
* Remove `scala.quoted.Quotes.reflect.{Tree.of, Term.of}`
* Remove `scala.quoted.{Unlifted, Const, Consts}`
@nicolasstucki nicolasstucki force-pushed the remove-deprecated-methods-from-library branch from f2123af to 951c250 Compare December 17, 2020 17:35
@anatoliykmetyuk anatoliykmetyuk merged commit 619f66a into scala:master Dec 17, 2020
@anatoliykmetyuk anatoliykmetyuk deleted the remove-deprecated-methods-from-library branch December 17, 2020 19:19
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants