Modernize and clean up the build. #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings `in Global` are moved to Build.settings. Otherwise they are added *twice* in every project. Project definitions use the `project` macro rather than the `Project()` factory, as is the customary notation since sbt 0.13. The `Defaults.coreDefaultSettings` is therefore dropped. The coding style of project definitions is adapted to the style shown in sbt documentations.
|
Review by @DarkDimius Best reviewed with the ?w=1 option to ignore whitespace changes. |
|
While you're at it, you may want to rebase and add #968 to your PR before we forget it. |
|
LGTM, I'd like to get this in because I'm hacking on Build.scala too. |
|
@smarter So, ready to merge? |
|
Yes. |
smarter
added a commit
that referenced
this pull request
Feb 23, 2016
Modernize and clean up the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings
in Globalare moved to Build.settings. Otherwise theyare added twice in every project.
Project definitions use the
projectmacro rather than theProject()factory, as is the customary notation since sbt0.13. The
Defaults.coreDefaultSettingsis therefore dropped.The coding style of project definitions is adapted to the style
shown in sbt documentations.