Refactor Diagnostic #1100
Refactor Diagnostic #1100
Conversation
Break it out from Reporter and eliminate all dependencies to Context. This is done so that Diagnostics can be part of a public and minimal compiler API.
| @@ -12,44 +12,9 @@ import config.Printers | |||
| import java.lang.System.currentTimeMillis | |||
| import typer.ErrorReporting.DiagnosticString | |||
There was a problem hiding this comment.
I think the weird test errors are because DiagnosticString does not exist anymore.
There was a problem hiding this comment.
Good analysis. Can you take it over and integrate the PR request directly
into your work?
On Wed, Feb 17, 2016 at 6:53 PM, Guillaume Martres <[email protected]
wrote:
In src/dotty/tools/dotc/reporting/Reporter.scala
#1100 (comment):@@ -12,44 +12,9 @@ import config.Printers
import java.lang.System.currentTimeMillis
import typer.ErrorReporting.DiagnosticStringI think the weird test errors are because DiagnosticString does not exist
anymore.—
Reply to this email directly or view it on GitHub
https://github.com/lampepfl/dotty/pull/1100/files#r53202952.
Martin Odersky
EPFL
|
Closing, will be integrated in my PR |
Break it out from Reporter and eliminate all dependencies
to Context. This is done so that Diagnostics can be part
of a public and minimal compiler API.
Review by @smarter