Refactor class parents handling #11475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you could also use |
smarter
force-pushed
the
classParents
branch
from
83a0561 to
dbbd60e
Compare
odersky
reviewed
Feb 22, 2021
smarter
force-pushed
the
classParents
branch
from
dbbd60e to
1d0c7ed
Compare
Before this commit we had: - Type#parents: for a ClassInfo, this is the parents of the class as seen from the ClassInfo prefix - ClassInfo#classParents: this is also the parents of the class but _not_ as seen from the ClassInfo prefix - ClassDenotation#classParents: this delegates to ClassInfo#parents and not to ClassInfo#classParents as one might think. To clear things up this commit: - Renames ClassInfo#classParents to declaredParents, to avoid accidentally using it instead of parents. - Remove ClassDenotation#classParents, one can always do `info.parents` instead. Additionally, this commit introduces ClassDenotation#parentSyms, to be used when one only care about the symbols of the parents. This method relies on `declaredParents` instead of `parents` which avoids any unnecessary call to `asSeenFrom`. It is used in `computeBaseData` instead of the old `classParents` to avoid a cyclic reference issue I ran into while working on an unrelated PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit we had:
the ClassInfo prefix
not as seen from the ClassInfo prefix
not to ClassInfo#classParents as one might think.
To clear things up this commit:
using it instead of parents.
info.parentsinstead.
Additionally, this commit introduces ClassDenotation#parentSyms, to be
used when one only care about the symbols of the parents. This method
relies on
înitParentsinstead ofparentswhich avoids anyunnecessary call to
asSeenFrom. It is used incomputeBaseDatainstead of the old
classParentsto avoid a cyclic reference issue Iran into while working on an unrelated PR.