Make convert available without import
#11786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
reviewed
Mar 17, 2021
| given Conversion[String, Int] = _.length | ||
| given Conversion[Int, String] = _.toString | ||
|
|
||
| def f(x: String): Int = x.convert | ||
| def g(x: Int): String = x.convert[String] | ||
| def g(x: Int): String = x.convert |
There was a problem hiding this comment.
This won't work if there are two Conversion[Int, Y] in scope for two different Ys.
There was a problem hiding this comment.
It does with a suitable type ascription, see updated test.
odersky
approved these changes
Mar 18, 2021
| given Conversion[String, Int] = _.length | ||
| given Conversion[Int, String] = _.toString | ||
|
|
||
| def f(x: String): Int = x.convert | ||
| def g(x: Int): String = x.convert[String] | ||
| def g(x: Int): String = x.convert |
sjrd
requested changes
Mar 19, 2021
rjolly
force-pushed
the
convert
branch
2 times, most recently
from
bec8412 to
ddd7449
Compare
sjrd
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.