Fixing annotations #118
Merged
Fixing annotations #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fixes: 1) Annotation#symbol now returns the correct annotations for classes as well as traits. 2) Typer copies annotations from Modifiers to Symbols
|
Review by @DarkDimius It would be best if this was integrated in the tailrec pull request. tailrec sholld look at symbol annotations instead of trees. Also right now, a number of lazyval tests fail after the change. @DarkDimius can you check why and if possible fix it? |
|
Either travis had an error, or this fix made tests hang. |
|
dotc.tests.dotc_core has finished first run, but second run didn't finish in 10 minutes. |
Instead of by-hand testing of modifier type.
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
Mar 19, 2025
Backport "Attempt to beta reduce only if parameters and arguments have same shape" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes: