Skip to content

Update protoquill #12187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki
Copy link
Contributor Author

@deusaquilus I noticed that protoquill master is failing in our master. Is this the failure from #12179?

@deusaquilus
Copy link
Contributor

Correct. I just commented all of that out though. Master build and tests are now all passing now.

@nicolasstucki nicolasstucki force-pushed the update-protoquill branch 2 times, most recently from eef042c to 07c08fc Compare April 23, 2021 13:43
@nicolasstucki nicolasstucki self-assigned this Apr 26, 2021
@nicolasstucki nicolasstucki force-pushed the update-protoquill branch 2 times, most recently from 3efb86b to 6fe9cb5 Compare April 29, 2021 07:20
@nicolasstucki
Copy link
Contributor Author

@deusaquilus it seems the latest master of protoquill is timing out. Could you take this over and try to make protoquill/master work with the latest dotty nightly?

@deusaquilus
Copy link
Contributor

Sure, I'll have a look. The issue probably is because it is depending on a SNAPSHOT version of quill-core-portable/quill-sql-portable that no-longer exists. I will publish regular versions of these things ASAP and try to fix this up by tomorrow. Thanks for the info!

@deusaquilus
Copy link
Contributor

Updated Proto-Quill master. Removed scalatest dependency. It should be working now.

@nicolasstucki nicolasstucki marked this pull request as ready for review May 4, 2021 19:32
@nicolasstucki
Copy link
Contributor Author

Updated to the latest master of protoquill

@deusaquilus
Copy link
Contributor

Thanks!

@deusaquilus
Copy link
Contributor

deusaquilus commented May 4, 2021

@nicolasstucki The stuff you did with Extractors.scala is absolutely amazing! I love it!
I need to ask though, is this approach with def stuff(using Quotes)(quotes.reflect.Term/TypeRepr/etc...) guaranteed to be possible in future versions of Scala? It would really be sad if in 3.1.0 all of this became broken and I had to go back to the old way of doing things because I'd already become reliant on the nicer way.

@odersky Any chance you can vouch for this transparent inline def quotes(using inline q: Quotes): q.type = q working and this pattern possible in future versions of Scala?

@anatoliykmetyuk anatoliykmetyuk merged commit c2d0b92 into scala:master May 5, 2021
@anatoliykmetyuk anatoliykmetyuk deleted the update-protoquill branch May 5, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants