-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Scaladoc: CSS fixes #12461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaladoc: CSS fixes #12461
Conversation
7cb0982
to
b6da347
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only isssue I see is that search and menu button should be sticky.
Is that intentional that on narrower screen search button loose the red gradient background?
Yes, it's intentional. I'm not an author of this CSS rule, though. I'm gonna take a look at search button because it hides halfway on scroll. |
b6da347
to
e7fae8a
Compare
@TheElectronWill Could you take a look at my latest commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found a fix for the wrapping difference between selected and unselected entries (see suggestions). It would be cleaner to use ch
instead of ex
but that's good enough (and slightly more portable).
Word-wrapping seem to work fine in Firefox and Chrome without all the hints generated by Ux
, I think it can be safely removed.
The new footer LGTM :)
But it doesn't work properly for package names and long class names because there's no spaces and browser wraps text in random place. Wrapping before dots and upper cases looks better for me |
e7fae8a
to
8968013
Compare
Wrapping looks good in theory, but not sure I'm a fan of how much wrapping there is. Feel like for any Scaladoc generated like this will see wrapping, and that is to me a sign that the sidebar should maybe be a bit wider? For comparision, Scaladoc for 2.13 is a tree, so it doesn't have to worry too much about it. Javadoc in the sidebar (that they no longer generate sadly) uses fontsize 12 (think Scaladoc's font size is better here) and a sidebar width of 30%. For me a width of 20% looks good, but that would have to be tweaked on smaller screens. |
Oh so that was the point! In that case yes, it's useful. |
8968013
to
0b1a5db
Compare
0b1a5db
to
9a20975
Compare
closes #12335
closes #12098
Current output will be uploaded to our server as a part of CI so I'll paste the link to it there.
@Katrix @nicolasstucki