Skip to content

Update document for DottyTypeStealer #12833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2021
Merged

Update document for DottyTypeStealer #12833

merged 2 commits into from
Jun 16, 2021

Conversation

tanishiking
Copy link
Member

See: #12830

And copied Type diagram from Types.scala to docs/docs/internals/type-system.md.

@romanowski romanowski requested a review from odersky June 16, 2021 09:28
@romanowski
Copy link
Contributor

changes in docs LGTM, but I think we need blessing from @odersky for changes in type-system.md

odersky
odersky approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the changes to typesystem.md

@odersky odersky merged commit 000a541 into scala:master Jun 16, 2021
@tanishiking tanishiking deleted the update-doc-dotty-type-stealer branch June 16, 2021 12:36
@tanishiking tanishiking mentioned this pull request Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanishiking @romanowski @odersky