CI: honor [skip test_windows_fast] request #13050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griggt
commented
Jul 11, 2021
Comment on lines
-127
to
-130
| || ( | ||
| github.event_name == 'pull_request' | ||
| && !contains(github.event.pull_request.body, '[skip ci]') | ||
| ) |
There was a problem hiding this comment.
The conditional was short-circuiting here, there are tests for both [skip ci] and [skip test_windows_fast] below.
anatoliykmetyuk
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, test_windows_fast would run even when [skip test_windows_fast] was requested.