REPL: emit parse warnings by reusing the reporter #13209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original report requires the -deprecation and -source:future flags, for which there is seems to be no support in repl.ScriptedTests. So switched to a non-deprecation syntax warning, that isn't guarded by -source. I might come back and add "pragma" support to the REPL scripts so I can move the test out of pending. Co-authored-by: Seth Tisue <[email protected]>
dwijnand
force-pushed
the
repl-issue-parse-warnings
branch
from
502fda1 to
438a041
Compare
lrytz
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
This is somewhat related to scala/scala@79ca1408c7
Reminds me that I need to test #12857 with the REPL.
dwijnand
commented
Jul 31, 2021
| @@ -243,7 +243,7 @@ class ReplDriver(settings: Array[String], | |||
| unfusedPhases(using ctx).collectFirst { case phase: CollectTopLevelImports => phase.imports }.get | |||
|
|
|||
| implicit val state = { | |||
| val state0 = newRun(istate) | |||
| val state0 = newRun(istate, parsed.reporter) | |||
| state0.copy(context = state0.context.withSource(parsed.source)) | |||
There was a problem hiding this comment.
Btw, before I wired the reporter through newRun I was adding it here with .fresh.setReporter(reporter) but that was breaking something to do with class-loading, which seemed complicated. I'm not sure if that's expected and if anyone knows why that happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original report requires the -deprecation and -source:future flags,
for which there is seems to be no support in repl.ScriptedTests. So
switched to a non-deprecation syntax warning, that isn't guarded by
-source.
I might come back and add "pragma" support to the REPL scripts so I can
move the test out of pending.
Co-authored-by: Seth Tisue [email protected]
Fixes #13208