-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Properly desugar inline given .. with ..
#14284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9b3cdc2
Properly desugar `inline given .. with ..`
nicolasstucki b0929f2
Disallow `transparent inline given .. with ..`
nicolasstucki e26f867
Add documentation on inline given instances
nicolasstucki 5664de0
Expand inline given instance docs
nicolasstucki 09a46f1
Add example
nicolasstucki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import scala.compiletime.* | ||
|
||
trait C[A] | ||
|
||
inline given [Tup <: Tuple]: C[Tup] with | ||
val cs = summonAll[Tuple.Map[Tup, C]] // error cannot reduce inline match with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
class T | ||
|
||
inline given fail1: T with | ||
val cs = scala.compiletime.summonAll[EmptyTuple] | ||
inline given fail2[X]: T with | ||
val cs = scala.compiletime.summonAll[EmptyTuple] | ||
inline given fail3(using DummyImplicit): T with | ||
val cs = scala.compiletime.summonAll[EmptyTuple] | ||
|
||
inline given ok1: T = new T: | ||
val cs = scala.compiletime.summonAll[EmptyTuple] | ||
inline given ok2[X]: T = new T: | ||
val cs = scala.compiletime.summonAll[EmptyTuple] | ||
inline given ok3(using DummyImplicit): T = new T: | ||
val cs = scala.compiletime.summonAll[EmptyTuple] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
trait Foo[A] { | ||
inline def foo(): Unit | ||
} | ||
|
||
inline given FooA[A]: Foo[A] with { | ||
inline def foo(): Unit = println() | ||
} | ||
def test1 = FooA.foo() | ||
|
||
inline given FooInt: Foo[Int] with { | ||
inline def foo(): Unit = println() | ||
} | ||
def test2 = FooInt.foo() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does transparent inline work / do anything useful here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sure that we do not hit the previous issue where the
summonAll
was not inlined due to theinline
flag that was kept by mistake on theclass fail1
.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, there are no testcases with transparent in this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I completely missed the transparent. I will add some test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transparent is failing for the wrong reason. I do not see how transparent would be useful here because we already have the precise type. I will disallow this combination and make sure the error message is correct.