Fixes for scala.Dynamic #1469
Merged
Fixes for scala.Dynamic #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
nicolasstucki
force-pushed
the
fix-scala.Dynamic
branch
from
968e75a to
7b32f65
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
fix-scala.Dynamic
branch
8 times, most recently
from
6e80157 to
ab58bfb
Compare
|
Review by @odersky |
| typedDynamicApply(qual, name, args, pt)(tree) | ||
| case _ => | ||
| handleUnexpectedFunType(tree, fun1) | ||
| tree.fun match { |
There was a problem hiding this comment.
Move up to line 603 into separate function.
nicolasstucki
force-pushed
the
fix-scala.Dynamic
branch
2 times, most recently
from
87c42fe to
1dbe908
Compare
nicolasstucki
force-pushed
the
fix-scala.Dynamic
branch
from
1dbe908 to
0ee74cc
Compare
|
Is there a way to see what was committed after my last review? |
|
LGTM now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.